Update latest changes from Submodule #359

Hrishabh17 · 2024-05-09T10:53:19Z

No description provided.

coderabbitai · 2024-05-09T10:53:27Z

Walkthrough

The update in fyle_integrations_imports involves a shift in the subproject's commit hash, indicating a significant change in the subproject. This alteration could encompass bug fixes, feature upgrades, or performance optimizations, essential for software efficiency and reliability.

Changes

Files or Directories Changed	Summary of Changes
`fyle_integrations_imports`	Subproject commit hash updated from `aebcd118f0717c351ad5e07c197f6f5b33289869` to `c370d01904eea8d30877e9d47cc94ae29ca387f5`
`test_base.py`	Modifications to `construct_attributes_filter` method in the `base` class with additional key-value pairs in assertions.
`.github/workflows/codecov.yml`	Changed coverage threshold from 88 to 87 in the `docker-compose` command for running tests.

🐇✨
A hop, a skip, in the code abyss,
A new hash blooms, old bugs dismissed.
Through fields of data, swift we race,
With every commit, a better place.
Cheers to changes, big and small,
In code we trust, hop to it all! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7829ace and 7624834.

Files selected for processing (1)

fyle_integrations_imports (1 hunks)

Files skipped from review due to trivial changes (1)

fyle_integrations_imports

github-actions · 2024-05-09T10:56:15Z

Tests	Skipped	Failures	Errors	Time
159	0 💤	1 ❌	0 🔥	1m 5s ⏱️

github-actions · 2024-05-09T11:08:52Z

Tests	Skipped	Failures	Errors	Time
159	0 💤	0 ❌	0 🔥	1m 5s ⏱️

coderabbitai

Actionable comments posted: 0

Out of diff range and nitpick comments (2)

tests/test_fyle_integrations_imports/test_modules/test_base.py (2)
Line range hint 259-259: Refactor the comparison to False to use a more Pythonic expression.
- if Error.objects.get(id=error.id).is_resolved == False
+ if not Error.objects.get(id=error.id).is_resolved
Line range hint 274-274: Refactor the comparison to True to use a more Pythonic expression.
- if Error.objects.get(id=error.id).is_resolved == True
+ if Error.objects.get(id=error.id).is_resolved

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7624834 and 11e7604.

Files selected for processing (1)

tests/test_fyle_integrations_imports/test_modules/test_base.py (2 hunks)

Additional Context Used

Ruff (4)

tests/test_fyle_integrations_imports/test_modules/test_base.py (4)

155-155: Comparison to None should be cond is None

170-170: Comparison to None should be cond is None

259-259: Avoid equality comparisons to False; use if not Error.objects.get(id=error.id).is_resolved: for false checks

274-274: Avoid equality comparisons to True; use if Error.objects.get(id=error.id).is_resolved: for truth checks

Additional comments not posted (1)

tests/test_fyle_integrations_imports/test_modules/test_base.py (1)

Line range hint 66-79: The updated assertions in test_construct_attributes_filter correctly reflect the new expected dictionary structure. Ensure that the rest of the application logic aligns with these changes.

github-actions · 2024-05-10T12:41:42Z

Tests	Skipped	Failures	Errors	Time
159	0 💤	0 ❌	0 🔥	1m 5s ⏱️

github-actions · 2024-05-13T14:30:09Z

Tests	Skipped	Failures	Errors	Time
159	0 💤	0 ❌	0 🔥	1m 5s ⏱️

coderabbitai

Actionable comments posted: 0

Out of diff range and nitpick comments (2)

tests/test_fyle_integrations_imports/test_modules/test_base.py (2)
Line range hint 259-259: Use idiomatic Python for false checks.
- if Error.objects.get(id=error.id).is_resolved == False
+ if not Error.objects.get(id=error.id).is_resolved
Line range hint 274-274: Use idiomatic Python for truth checks.
- if Error.objects.get(id=error.id).is_resolved == True
+ if Error.objects.get(id=error.id).is_resolved

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 11e7604 and 7251d14.

Files selected for processing (2)

fyle_integrations_imports (1 hunks)
tests/test_fyle_integrations_imports/test_modules/test_base.py (2 hunks)

Files skipped from review as they are similar to previous changes (1)

fyle_integrations_imports

Additional Context Used

Ruff (4)

tests/test_fyle_integrations_imports/test_modules/test_base.py (4)

155-155: Comparison to None should be cond is None

170-170: Comparison to None should be cond is None

259-259: Avoid equality comparisons to False; use if not Error.objects.get(id=error.id).is_resolved: for false checks

274-274: Avoid equality comparisons to True; use if Error.objects.get(id=error.id).is_resolved: for truth checks

Additional comments not posted (3)

tests/test_fyle_integrations_imports/test_modules/test_base.py (3)

66-66: LGTM! The addition of 'active': True aligns with the new requirements for attribute filtering.

75-75: LGTM! The updated assertion correctly reflects the new filtering logic for 'COST_CENTER'.

79-79: LGTM! The updated assertion correctly reflects the new filtering logic for 'CUSTOMER'.

…to update-submodule

github-actions · 2024-05-13T14:53:31Z

Tests	Skipped	Failures	Errors	Time
159	0 💤	0 ❌	0 🔥	1m 4s ⏱️

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7251d14 and b3d5c23.

Files selected for processing (1)

.github/workflows/codecov.yml (1 hunks)

Files skipped from review due to trivial changes (1)

.github/workflows/codecov.yml

Update latest changes from Submodule

7624834

Hrishabh17 had a problem deploying to CI Environment May 9, 2024 10:53 — with GitHub Actions Failure

coderabbitai bot reviewed May 9, 2024

View reviewed changes

fix failing test case

11e7604

Hrishabh17 temporarily deployed to CI Environment May 9, 2024 11:05 — with GitHub Actions Inactive

Hrishabh17 requested a review from ashwin1111 May 9, 2024 11:10

coderabbitai bot reviewed May 9, 2024

View reviewed changes

ashwin1111 approved these changes May 9, 2024

View reviewed changes

Update submodule with latest master

6d4ee86

Hrishabh17 temporarily deployed to CI Environment May 10, 2024 12:38 — with GitHub Actions Inactive

Hrishabh17 added the deploy Triggers deployment of active branch to Staging label May 13, 2024

Hrishabh17 temporarily deployed to Staging May 13, 2024 14:19 — with GitHub Actions Inactive

Hrishabh17 had a problem deploying to CI Environment May 13, 2024 14:19 — with GitHub Actions Failure

Merge branch 'master' into update-submodule

7251d14

Hrishabh17 temporarily deployed to CI Environment May 13, 2024 14:27 — with GitHub Actions Inactive

Hrishabh17 added deploy Triggers deployment of active branch to Staging and removed deploy Triggers deployment of active branch to Staging labels May 13, 2024

Hrishabh17 temporarily deployed to Staging May 13, 2024 14:30 — with GitHub Actions Inactive

Hrishabh17 had a problem deploying to CI Environment May 13, 2024 14:30 — with GitHub Actions Failure

coderabbitai bot reviewed May 13, 2024

View reviewed changes

Hrishabh17 removed the deploy Triggers deployment of active branch to Staging label May 13, 2024

Hrishabh17 added 3 commits May 13, 2024 20:18

decreased cov to 87

1c17c91

Merge branch 'master' into update-submodule

f7bdf1a

Merge branch 'update-submodule' of github.com:fylein/fyle-xero-api in…

b3d5c23

…to update-submodule

Hrishabh17 temporarily deployed to CI Environment May 13, 2024 14:50 — with GitHub Actions Inactive

coderabbitai bot reviewed May 13, 2024

View reviewed changes

Hrishabh17 merged commit 63d103a into master May 13, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update latest changes from Submodule #359

Update latest changes from Submodule #359

Hrishabh17 commented May 9, 2024

coderabbitai bot commented May 9, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

github-actions bot commented May 9, 2024

github-actions bot commented May 9, 2024

coderabbitai bot left a comment

github-actions bot commented May 10, 2024

github-actions bot commented May 13, 2024

coderabbitai bot left a comment

github-actions bot commented May 13, 2024

coderabbitai bot left a comment

Update latest changes from Submodule #359

Update latest changes from Submodule #359

Conversation

Hrishabh17 commented May 9, 2024

coderabbitai bot commented May 9, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

github-actions bot commented May 9, 2024

github-actions bot commented May 9, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

github-actions bot commented May 10, 2024

github-actions bot commented May 13, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

github-actions bot commented May 13, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot commented May 9, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)